Re: Observations in Parallel Append

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Observations in Parallel Append
Date: 2017-12-25 04:37:41
Message-ID: CAA4eK1L74yRyHUp+da-sRAcPUS2og1Qydj0WB5sqJgjzm0hiPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 24, 2017 at 12:06 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Dec 22, 2017 at 6:18 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
>> Also, don't we need to use parallel_divisor for partial paths instead
>> of non-partial paths as those will be actually distributed among
>> workers?
>
> Uh, that seems backwards to me. We're trying to estimate the average
> number of rows per worker.
>

Okay, but is it appropriate to use the parallel_divisor? The
parallel_divisor means the contribution of all the workers (+
leader_contribution) whereas for non-partial paths there will be
always only the subset of workers which will operate on them.
Consider a case with one non-partial subpath and five partial subpaths
with six as parallel_divisor, now the current code will try to divide
the rows of non-partial subpath with respect to six workers. However,
in reality, there will always be one worker which will execute that
path.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-12-25 04:52:32 Re: [HACKERS] Proposal: Local indexes for partitioned table
Previous Message Huong Dangminh 2017-12-25 04:26:11 RE: User defined data types in Logical Replication