Re: row filtering for logical replication

On Wed, Nov 10, 2021 at 12:36 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Mon, Nov 8, 2021 at 5:53 PM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > 3) v37-0005
> >
> > - no parse nodes of any kind other than Var, OpExpr, Const, BoolExpr, FuncExpr
> >
> > I think there could be other node type which can also be considered as simple
> > expression, for exmaple T_NullIfExpr.
>
> The current walker restrictions are from a previously agreed decision
> by Amit/Tomas [1] and from an earlier suggestion from Andres [2] to
> keep everything very simple for a first version.
>
> Yes, you are right, there might be some additional node types that
> might be fine, but at this time I don't want to add anything different
> without getting their approval to do so. Anyway, additions like this
> are all candidates for a future version of this row-filter feature.
>

I think we can consider T_NullIfExpr unless you see any problem with the same.

> >
> > Personally, I think it's natural to only check the IMMUTABLE and
> > whether-user-defined in the new function rowfilter_walker. We can keep the
> > other row-filter errors which were thrown for EXPR_KIND_PUBLICATION_WHERE in
> > the 0001 patch.
> >
>
> YMMV. IMO it is much more convenient for all the filter validations to
> be centralized just in one walker function instead of scattered all
> over the place like they were in the 0001 patch.
>

+1.

Few comments on the latest set of patches (v39*)
=======================================
0001*
1.
ObjectAddress
-publication_add_relation(Oid pubid, PublicationRelInfo *targetrel,
+publication_add_relation(Oid pubid, PublicationRelInfo *pri,
bool if_not_exists)
{
Relation rel;
HeapTuple tup;
Datum values[Natts_pg_publication_rel];
bool nulls[Natts_pg_publication_rel];
- Oid relid = RelationGetRelid(targetrel->relation);
+ Relation targetrel = pri->relation;

I don't think such a renaming (targetrel-->pri) is warranted for this
patch. If we really want something like this, we can probably do it in
a separate patch but I suggest we can do that as a separate patch.

2.
+ * The OptWhereClause (row-filter) must be stored here
+ * but it is valid only for tables. If the ColId was
+ * mistakenly not a table this will be detected later
+ * in preprocess_pubobj_list() and an error thrown.

/error thrown/error is thrown

0003*
3. In pgoutput_row_filter(), the patch is finding pub_relid when it
should already be there in RelationSyncEntry->publish_as_relid found
during get_rel_sync_entry call. Is there a reason to do this work
again?

4. I think we should add some comments in pgoutput_row_filter() as to
why we are caching the row_filter here instead of
get_rel_sync_entry()? That has been discussed multiple times so it is
better to capture that in comments.

5. Why do you need a separate variable rowfilter_valid to indicate
whether a valid row filter exists? Why exprstate is not sufficient?
Can you update comments to indicate why we need this variable
separately?

0004*
6. In rowfilter_expr_checker(), the expression tree is traversed
twice, can't we traverse it once to detect all non-allowed stuff? It
can be sometimes costly to traverse the tree multiple times especially
when the expression is complex and it doesn't seem acceptable to do so
unless there is some genuine reason for the same.

7.
+static void
+rowfilter_expr_checker(Publication *pub, Node *rfnode, Relation rel)

Keep the rel argument before whereclause as that makes the function
signature better.

With Regards,
Amit Kapila.