| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_ctl status with nonexistent data directory |
| Date: | 2014-03-08 03:38:31 |
| Message-ID: | CAA4eK1L46eTSRX-jWW9Au5C7fJ_+LBa7McQ6DZBaCCJz0OKfiA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 7, 2014 at 7:59 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Mar 7, 2014 at 07:18:04PM +0530, Amit Kapila wrote:
>> > OK, done with the attached patch Three is returned for status, but one
>> > for other cases.
>>
>> I think it would have been better if it return status as 4 for cases where
>> directory/file is not accessible (current new cases added by this patch).
>>
>> I think status 3 should be only return only when the data directory is valid
>> and pid file is missing, because in script after getting this code, the next
>> thing they will probably do is to start the server which doesn't seem a
>> good fit for newly added cases.
>
> OK, I have updated the attached patch to reflect this, and added a C
> comment.
This is fine, do you think we should mention about this in docs?
I have added one line in docs (updated patch attached), if you think
it makes sense then add it otherwise ignore it.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| pg_ctl-v2.diff | text/plain | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-03-08 03:46:56 | Re: pg_upgrade: delete_old_cluster.sh issues |
| Previous Message | Peter Eisentraut | 2014-03-08 03:28:02 | Re: extension_control_path |