| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add contrib/pg_logicalsnapinspect |
| Date: | 2025-03-05 09:12:15 |
| Message-ID: | CAA4eK1L0bZbZOr8-VNFXDfqaTwggdf_-HTAsneui+_ozMTvZQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 5, 2025 at 12:47 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Tue, Mar 04, 2025 at 10:25:57PM -0800, Masahiko Sawada wrote:
> > On Tue, Mar 4, 2025 at 1:56 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > >
> > Thank you for the report.
>
> +1
>
> > It seems that bgwriter wrote another RUNNING_XACTS record during the
> > test, making the logical decoding write an extra snapshot on the disk.
>
> Yup.
>
> > One way to stabilize the regression test would be that we check if
> > there is a serialized snapshot that has expected number of catchange
> > transactions and number of committed transactions, instead of dumping
> > all serialized snapshots.
>
> Agree, PFA a patch doing so.
>
It would be better if you could add a few comments atop the
permutation line to explain the working of the test. We have it for
other decoding-related tests. See
test_decoding/specs/subxact_without_top.spec for reference.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-03-05 09:22:07 | Re: Commit fest 2025-03 |
| Previous Message | Richard Guo | 2025-03-05 09:09:05 | Re: Wrong results with subquery pullup and grouping sets |