Re: condition variables

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: condition variables
Date: 2016-09-06 13:14:44
Message-ID: CAA4eK1L+f3NitMxRbwgCAae9O+Gj1OCTodV4EkLFuiRGTSg39A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 6, 2016 at 5:29 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Sep 5, 2016 at 3:17 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Mon, Aug 15, 2016 at 10:35 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>>> Don't you need to set proc->cvSleeping = false in ConditionVariableSignal?
>>>>
>>>> I poked at this a bit... OK, a lot... and have some feedback:
>>>>
>>>> 1. As above, we need to clear cvSleeping before setting the latch.
>>>
>>> Right, OK.
>>>
>>
>> I have independently faced this problem while using your patch and for
>> now I have updated my local copy. If possible, please send an updated
>> patch as this patch could be used for development of various
>> parallelism projects.
>
> Thomas already posted an updated patch in the same message where he
> reported the problem.
>

Oops, I missed that, will use the same.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-09-06 13:17:55 Re: Bug in 9.6 tuplesort batch memory growth logic
Previous Message Amit Langote 2016-09-06 13:07:23 Re: Declarative partitioning - another take