From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Euler Taveira <euler(at)eulerto(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: About a recently-added message |
Date: | 2024-02-15 02:56:18 |
Message-ID: | CAA4eK1L+P=7RPh1UEAv=vdaWHBsU0zq5uJssBhPEz9_L-KddOA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
>
> Now, I am less clear about whether to quote "logical" or not in the
> above message. Do you have any suggestions?
>
>
> The possible confusion comes from the fact that the sentence contains "must be"
> in the middle of a comparison expression. For pg_createsubscriber, we are using
>
> publisher requires wal_level >= logical
>
> I suggest to use something like
>
> slot synchronization requires wal_level >= logical
>
This sounds like a better idea but shouldn't we directly use this in
'errmsg' instead of a separate 'errhint'? Also, if change this, then
we should make a similar change for other messages in the same
function.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2024-02-15 03:06:39 | Re: Can we include capturing logs of pgdata/pg_upgrade_output.d/*/log in buildfarm |
Previous Message | Amit Kapila | 2024-02-15 02:48:59 | Re: Synchronizing slots from primary to standby |