Re: wake up logical workers after ALTER SUBSCRIPTION

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: 2022-11-22 11:29:28
Message-ID: CAA4eK1KzPvvGfK1mY3gvfsLEEWS+moRjWbmbGExLRQHM41P6YA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 22, 2022 at 6:11 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> While working on avoiding unnecessary wakeups in logical/worker.c (as was
> done for walreceiver.c in 05a7be9), I noticed that the tests began taking
> much longer. This seems to be caused by the reduced frequency of calls to
> maybe_reread_subscription() in LogicalRepApplyLoop().
>

I think it would be interesting to know why tests started taking more
time after a reduced frequency of calls to
maybe_reread_subscription(). IIRC, we anyway call
maybe_reread_subscription for each xact.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-11-22 11:32:35 Re: Fix comments atop pg_get_replication_slots
Previous Message Simon Riggs 2022-11-22 11:16:28 Re: Damage control for planner's get_actual_variable_endpoint() runaway