From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: BUG #11350: ALTER SYSTEM is not DDL? |
Date: | 2014-09-19 11:35:23 |
Message-ID: | CAA4eK1KvYoU+P9m1Y=hWDr-Ob4T+T_yMsf9Shv3Qn+XGGh0vPg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Fri, Sep 19, 2014 at 1:05 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
>
> On 2014-09-19 12:50:24 +0530, Amit Kapila wrote:
> > On Fri, Sep 19, 2014 at 9:49 AM, Craig Ringer <craig(at)2ndquadrant(dot)com>
wrote:
> > >
> > > On 09/05/2014 08:32 PM, Amit Kapila wrote:
> > > >
> > > > and Alter System affects at system level, both of these can't
> > > > be considered as DDL, may be a separate category.
> > >
> > > Like CREATE USER / CREATE ROLE / CREATE DATABASE ?
> > >
> > > All those are logged as DDL.
> >
> > They are different from ALTER SYSTEM in terms that they create/modify
> > the object (here object can be any database or cluster object) property.
> >
> > Can you tell me that if we want to make ALTER SYSTEM as DDL, then
> > why SET or CHECKPOINT commands can't be DDL?
>
> Really? Because neither has persistent effects?
I am not sure if persistent effects should be considered while defining
type of statement. Statements that define database structure or schema
in some way should be considered as DDL statements.
I am not able to convince myself that ALTER SYSTEM should be a
DDL command, however if you and Stephen feels strongly about it
then lets do it that way. I think there is already a patch in this thread
which defines it as DDL (though I haven't checked it yet). Do you
expect anything more?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | matthew.vita | 2014-09-19 13:48:54 | BUG #11454: plperl apt problem |
Previous Message | Maxim Boguk | 2014-09-19 10:49:47 | Re: BUG #11441: Weird (and seems wrong) behavior of partial indexes with order by/limit |