From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2021-03-21 07:37:16 |
Message-ID: | CAA4eK1KvXA34S24My1qnRhOn+w30b2FdGNNzqh1pm0ENveGJJw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 20, 2021 at 10:09 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Sat, Mar 20, 2021 at 1:35 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> On Fri, Mar 19, 2021 at 5:03 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>> >
>> > Missed the patch - 0001, resending.
>> >
>>
>> I have made miscellaneous changes in the patch which includes
>> improving comments, error messages, and miscellaneous coding
>> improvements. The most notable one is that we don't need an additional
>> parameter in walrcv_startstreaming, if the two_phase option is set
>> properly. My changes are in v63-0002-Misc-changes-by-Amit, if you are
>> fine with those, then please merge them in the next version. I have
>> omitted the dev-logs patch but feel free to submit it. I have one
>> question:
>>
>
> I am fine with these changes. I see that Peter has already merged in these changes.
>
I have further updated the patch to implement unique GID on the
subscriber-side as discussed in the nearby thread [1]. That requires
some changes in the test. Additionally, I have updated some comments
and docs. Let me know what do you think about the changes?
--
With Regards,
Amit Kapila.
Attachment | Content-Type | Size |
---|---|---|
v65-0001-Add-support-for-prepared-transactions-to-built-i.patch | application/octet-stream | 103.4 KB |
v65-0002-Support-2PC-txn-subscriber-tests.patch | application/octet-stream | 27.9 KB |
v65-0003-Fix-apply-worker-dev-logs.patch | application/octet-stream | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-03-21 07:39:48 | Re: Logical Replication vs. 2PC |
Previous Message | Peter Eisentraut | 2021-03-21 07:13:15 | Re: [PATCH] Identify LWLocks in tracepoints |