From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
Subject: | Re: dropdb --force |
Date: | 2019-11-23 11:12:10 |
Message-ID: | CAA4eK1KrtXiEgLbAdaqAnDhBf_fHoH5wQwg6B5Rm1HRM7_gUBQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 22, 2019 at 3:16 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for fixing the comments. The changes looks fine to me. I have
> fixed the first comment, attached patch has the changes for the same.
>
Few comments:
--------------------------
1. There is a lot of duplicate code in this test. Basically, almost
the same code is used once to test Drop Database command and dropdb.
I think we can create a few sub-functions to avoid duplicate code, but
do we really need to test the same thing once via command and then by
dropdb utility? I don't think it is required, but even if we want to
do so, then I am not sure if this is the right test script. I suggest
removing the command related test.
2.
ok( TestLib::pump_until(
+ $killme,
+ $psql_timeout,
+ \$killme_stderr,
+ qr/FATAL: terminating connection due to administrator command/m
+ ),
+ "psql query died successfully after SIGTERM");
Extra space before TestLib.
3.
+=item pump_until(proc, psql_timeout, stream, untl)
I think moving pump_until to TestLib is okay, but if you are making it
a generic function to be used from multiple places, it is better to
name the variable as 'timeout' instead of 'psql_timeout'
4. Have you ran perltidy, if not, can you please run it? See
src/test/perl/README for the recommendation.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2019-11-23 14:10:35 | Re: WAL archive is lost |
Previous Message | Andreas Karlsson | 2019-11-23 09:44:47 | Re: [PATCH] Tiny optimization. |