From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com> |
Subject: | Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)" |
Date: | 2018-06-19 03:36:34 |
Message-ID: | CAA4eK1KrGz-p_4npEKsjwziv9z_6YUm5y0-NGcQf_W3bf732Ww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 18, 2018 at 3:09 PM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> On 16 June 2018 at 19:30, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Sat, Jun 16, 2018 at 10:44 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> Yeah, or perhaps disallow creation of any partial paths at the first
>>> place like in attached. This will save us some work as well.
>>>
>>
>> Attached patch contains test case as well. I have tried to come up
>> with some simple test, but couldn't come up with anything much simpler
>> than reported by Rajkumar, so decided to use the test case provided by
>> him.
>>
>
> Thanks for the patch. I had a look at it, and it looks good to me. One
> minor comment :
>
> +-- Parallel Append is not be used when the subpath depends on the outer param
> "is not be used" => "is not to be used"
>
Fixed in the attached patch. I will wait for a day or two to see if
Tom or Robert wants to say something and then commit.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
fix_pa_path_generation_v3.patch | application/octet-stream | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2018-06-19 03:59:07 | Re: Pluggable storage |
Previous Message | Haribabu Kommi | 2018-06-19 03:19:29 | Re: Libpq support to connect to standby server as priority |