Re: [bug fix] pg_ctl always uses the same event source

On Mon, Jan 20, 2014 at 5:38 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
>>
>> Do you think without this the problem reported by you is resolved
>> completely.
>> User can hit same problem, if he tries to follow similar steps mentioned
>> in
>> your first mail. I had tried below steps based on description in your
>> first mail:
>>
>> If user register/unregister different versions of pgevent.dll blindly,
>> then I think
>> any fix in this area could not prevent the error "event source not found"
>
>
> OK, I'll add a check to prevent duplicate registration of the same event
> source with the message:
>
> "The specified event source is already registered."
>
> Please correct me if there's better expression in English.

How about below message:

event source "<event_source_name>" is already registered.

This can make it more consistent with any other message in PG,
example create table.

> Are there any other suggestions to make this patch ready for committer?

Today, I reviewed the patch again and found it okay, except a small
inconsistency which is about default event source name in
postgresql.conf, all other places it's changed except in .conf file.
Do you think it makes sense to change there as well?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com