Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry
Date: 2025-01-23 12:11:31
Message-ID: CAA4eK1Km_MnYRR681TKO117DuuKsCrJ_G4SfsSDbb8-8fwvgKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jan 23, 2025 at 4:56 PM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>
> On 1/22/25 06:34, Amit Kapila wrote:
> > Doc: Update the interaction of tablesync with wal_retrieve_retry_interval.
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314
>
> Hi,
>
> In this sentence :
>
> "The initial data in existing subscribed tables are snapshotted and
> copied in a parallel instances of a special kind of apply process."
>
> "copied in a parallel instances" seems wrong. It should be either
> (1) singular "in a parallel instance" or
> (2) plural "in parallel instances"
>
> I'm not sure which is meant.
>

I meant the latter. It is a typo. I will fix it.

> I also wonder if 'instance' is actually
> the correct word here at all; see the Glossary definition of 'instance':
>

It is not introduced by this patch but sounds correct to me because
the apply worker launches multiple table sync workers and they do
communicate via different states to finish the initial
synchronization.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Previous Message Erik Rijkers 2025-01-23 11:26:06 Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry

Browse pgsql-hackers by date

  From Date Subject
Previous Message Yura Sokolov 2025-01-23 12:03:04 Re: [RFC] Lock-free XLog Reservation from WAL