Re: Fix pg_buffercache document

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix pg_buffercache document
Date: 2020-05-08 04:36:33
Message-ID: CAA4eK1KhySMe+C2Whi3VpEtXBZtY-F34UyVSxich-ocOSzH_8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 7, 2020 at 4:02 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, May 7, 2020 at 2:53 PM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > >
> > > There is a typo in the patch (queris/queries). How about if slightly
> > > reword it as "Since buffer manager locks are not taken to copy the
> > > buffer state data that the view will display, accessing
> > > <structname>pg_buffercache</structname> view has less impact on normal
> > > buffer activity but it doesn't provide a consistent set of results
> > > across all buffers. However, we ensure that the information of each
> > > buffer is self-consistent."?
> >
> > Thank you for your idea. Agreed.
> >
> > Attached the updated version patch.
> >
>
> LGTM. I will commit this tomorrow unless there are more comments.
>

Pushed.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-05-08 05:02:11 Re: Logical replication subscription owner
Previous Message Noah Misch 2020-05-08 04:22:02 Re: PG 13 release notes, first draft