| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: parallel mode and parallel contexts |
| Date: | 2015-01-08 11:52:26 |
| Message-ID: | CAA4eK1KaNw6Rsr1eCv8tD4FPJFOurGCYU-HdsuOEkuJ9WNdaRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 7, 2015 at 11:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> I have little doubt that this version is still afflicted with various
> bugs, and the heavyweight locking issue remains to be dealt with, but
> on the whole I think this is headed in the right direction.
>
+ParallelMain(Datum main_arg)
{
..
+ /*
+ * Now that we have a resource owner, we can attach to the dynamic
+ * shared memory
segment and read the table of contents.
+ */
+ seg = dsm_attach(DatumGetInt32(main_arg));
Here, I think DatumGetUInt32() needs to be used instead of
DatumGetInt32() as the segment handle is uint32.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-08 12:19:23 | Re: Proposal: Log inability to lock pages during vacuum |
| Previous Message | Amit Kapila | 2015-01-08 11:47:58 | Re: Parallel Seq Scan |