| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: A doubt about a newly added errdetail |
| Date: | 2022-09-26 12:03:46 |
| Message-ID: | CAA4eK1KY=v9zJwxADPzYGGD7B99mqryFJZweoHtcV_yD8vbnOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 26, 2022 at 4:45 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
>
> Attach the patch. (The patch can apply on both HEAD and PG15)
>
The patch looks good to me.
*
- errmsg("cannot add schema to the publication"),
+ errmsg("cannot add schema to publication \"%s\"",
+ stmt->pubname),
I see that you have improved an additional message in the patch which
appears okay to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2022-09-26 12:37:28 | Re: Allow foreign keys to reference a superset of unique columns |
| Previous Message | Amit Kapila | 2022-09-26 12:00:11 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |