| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Few new warnings have been introduced in windows build (jsonb_util.c) |
| Date: | 2014-03-27 04:35:45 |
| Message-ID: | CAA4eK1KY=+vsYhiLzVRVLmQCn8L+VJPfiJQgzdVoQ2dUnejqag@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Few new warnings have been introduced in windows build.
1>e:\workspace\postgresql\master\postgresql\src\backend\utils\adt\jsonb_util.c(802):
warning C4715: 'JsonbIteratorNext' : not all control paths return a
value
1>e:\workspace\postgresql\master\postgresql\src\backend\utils\adt\jsonb_util.c(1042):
warning C4715: 'JsonbDeepContains' : not all control paths return a
value
1>e:\workspace\postgresql\master\postgresql\src\backend\utils\adt\jsonb_util.c(1175):
warning C4715: 'compareJsonbScalarValue' : not all control paths
return a value
These are quite similar to what we have fixed some time back.
Attached patch fixes these warnings. I am not sure about
fix of warning in 'JsonbIteratorNext', as there is no invalid value
for JSONB processing.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| silence_warning_jsonb-v1.patch | application/octet-stream | 711 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2014-03-27 08:04:56 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Previous Message | Peter Eisentraut | 2014-03-27 04:11:28 | Re: Minimum supported version of Python? |