| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum |
| Date: | 2020-07-04 07:02:21 |
| Message-ID: | CAA4eK1KXKQc6J_X3qNVBtatfW3xP8H76uOWuD1MFBQw2djNPKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> On Fri, 3 Jul 2020 at 17:07, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > While checking through the code I found that some of the function
> > parameters in reorderbuffer & vacuumlazy are not used. I felt this
> > could be removed. I'm not sure if it is kept for future use or not.
> > Attached patch contains the changes for the same.
> > Thoughts?
> >
>
> For the part of parallel vacuum change, it looks good to me.
>
Unlike ReorderBuffer, this change looks fine to me as well. This is a
quite recent (PG13) change and it would be good to remove it now. So,
I will push this part of change unless I hear any objection in a day
or so.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-07-04 09:19:46 | Re: Default setting for enable_hashagg_disk (hash_mem) |
| Previous Message | Fabien COELHO | 2020-07-04 06:47:53 | Re: Missing "Up" navigation link between parts and doc root? |