| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2020-09-21 09:57:05 |
| Message-ID: | CAA4eK1KWiRAUSb_wSvT4pPky7w-UUzht=LYuTBweDGZ41fqkzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 21, 2020 at 12:36 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> > Why can't we call ReorderBufferCleanupTXN() from
> > ReorderBufferFinishPrepared after your changes?
> >
>
> Since the truncate already removed the changes, it would fail on the
> below Assert in ReorderBufferCleanupTXN()
> /* Check we're not mixing changes from different transactions. */
> Assert(change->txn == txn);
>
The changes list should be empty by that time because we removing each
change from the list:, see code "dlist_delete(&change->node);" in
ReorderBufferTruncateTXN. If you are hitting the Assert as you
mentioned then I think the problem is something else.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2020-09-21 10:09:47 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Ashutosh Sharma | 2020-09-21 09:55:50 | Logical replication from PG v13 and below to PG v14 (devel version) is not working. |