From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
Cc: | Euler Taveira <euler(at)eulerto(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Subject: | Re: missing documentation for streaming in-progress transactions |
Date: | 2021-04-09 04:09:16 |
Message-ID: | CAA4eK1KTShNG-mpAtFGaOvYaYbUx43ynhJ_ZiPJGcQFVVZ0MmQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 9, 2021 at 8:29 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Fri, Apr 9, 2021 at 10:23 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>>
>>
>> I didn't like this style because it is not descriptive enough. It is also not a
>> style adopted by Postgres. I suggest to add something like "This field was
>> introduced in version 2" or "This field is available since version 2" after the
>> field description.
>
>
> I have updated this to "Since protocol version 2"
>>
>>
>> + Xid of the sub-transaction (will be same as xid of the transaction for top-level
>> + transactions).
>> +</para>
>>
>> Although, sub-transaction is also used in the documentation, I suggest to use
>> subtransaction. Maybe change the other sub-transaction occurrences too.
>
>
> Updated.
>
I don't like repeating the same thing for all new messages. So added
separate para for the same and few other changes. See what do you
think of the attached?
--
With Regards,
Amit Kapila.
Attachment | Content-Type | Size |
---|---|---|
v5-0001-doc-Update-information-of-new-messages-for-logica.patch | application/octet-stream | 7.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-04-09 04:14:32 | Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*) |
Previous Message | Thomas Munro | 2021-04-09 04:01:28 | Re: PostmasterIsAlive() in recovery (non-USE_POST_MASTER_DEATH_SIGNAL builds) |