| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 |
| Date: | 2023-02-18 03:37:59 |
| Message-ID: | CAA4eK1KT6nAkBd9wQeo08bMU=GwToD9Knz8XTCe-AUu88RjpRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 17, 2023 at 9:43 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2023-02-17 08:30:09 +0530, Amit Kapila wrote:
> > Thanks, I was not completely sure about whether we need to bump
> > XLOG_PAGE_MAGIC for this patch as this makes the additional space just
> > by changing the datatype of one of the members of the existing WAL
> > record. We normally change it for the addition/removal of new fields
> > aka change in WAL record format, or addition of a new type of WAL
> > record. Does anyone else have an opinion/suggestion on this matter?
>
> I'd definitely change it - the width of a field still means you can't really
> parse the old WAL sensibly anymore.
>
Okay, thanks for your input. I'll push this patch early next week.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-02-18 04:01:30 | Re: pg_upgrade and logical replication |
| Previous Message | Imseih (AWS), Sami | 2023-02-18 02:46:27 | Re: Add index scan progress to pg_stat_progress_vacuum |