Re: [HACKERS] logical decoding of two-phase transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-01-09 12:40:43
Message-ID: CAA4eK1KOVifWtP_6y8y4SkaOJn=4XQVWaZQM-B4S-F=Cn7=mxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 9, 2021 at 12:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jan 5, 2021 at 4:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jan 5, 2021 at 2:11 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> > >
> > >
> > > I've addressed the above comments and the patch is attached. I've
> > > called it v36-0007.
> > >
> >
> > Thanks, I have pushed this after minor wordsmithing.
> >
>
> The test case is failing on one of the build farm machines. See email
> from Tom Lane [1]. The symptom clearly shows that we are decoding
> empty xacts which can happen due to background activity by autovacuum.
> I think we need a fix similar to what we have done in
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=82a0ba7707e010a29f5fe1a0020d963c82b8f1cb.
>
> I'll try to reproduce and provide a fix for this later today or tomorrow.
>

I have pushed the fix.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-01-09 12:41:39 Re: Improper use about DatumGetInt32
Previous Message vignesh C 2021-01-09 11:51:06 Re: Added schema level support for publication.