| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dynamic Shared Memory stuff |
| Date: | 2014-04-16 02:46:06 |
| Message-ID: | CAA4eK1KNm-r1XbpK1aQEWT8Pi+y=cG7=-p6WpQvGb034DrhQgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 16, 2014 at 3:01 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Apr 15, 2014 at 12:33 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Mon, Apr 14, 2014 at 10:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> For the create case, I'm wondering if we should put the block that
>>> tests for !hmap *before* the _dosmaperr() and check for EEXIST. What
>>> is your opinion?
>>
>> Either way is okay, but I think the way you are suggesting is better as it
>> will make code consistent with other place (PGSharedMemoryCreate()).
>
> OK, can you prepare a patch?
Please find attached patch to address this issue.
One minor point to note is that now we have to call GetLastError() twice,
once inside error path and once to check EEXIST, but I think that is okay
as existing code in PGSharedMemoryCreate() does it that way.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_dsm_invalid_errcode_issue-v2.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-04-16 02:51:14 | Re: PostgreSQL in Windows console and Ctrl-C |
| Previous Message | David G Johnston | 2014-04-16 02:23:40 | Re: The question about the type numeric |