Re: Make default subscription streaming option as Parallel

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make default subscription streaming option as Parallel
Date: 2024-10-18 11:54:40
Message-ID: CAA4eK1KMN_TRV4NjA_JBuvJ=cJYMX6_vr58FQ0gNzDjA3ouoZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 18, 2024 at 9:48 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Oct 8, 2024 at 3:38 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> On Tue, Oct 8, 2024 at 2:25 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>> >
>> > On Mon, Oct 7, 2024 at 4:03 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>> > >
>> >
>> > With parallel streaming as default, do you think there is a need to
>> > increase the default for 'max_logical_replication_workers' as IIUC
>> > parallel workers are taken from the same pool.
>> >
>>
>> Good question. But then one may say that we should proportionately
>> increase max_worker_processes as well. I don't know what should be
>> reasonable new defaults. I think we should make parallel streaming as
>> default and then wait for some user feedback before changing other
>> defaults.
>>
>
> I agree, actually streaming of in progress transactions is a useful feature for performance in case of large transactions, so it makes sense to make it "on" by default. So +1 from my side.
>

Your response is confusing. AFAIU, this proposal is to change the
default value of the streaming option to 'parallel' but you are
suggesting to make 'on' as default which is different from the
proposed default but OTOH you are saying +1 as well. So, both can't be
true.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2024-10-18 12:09:04 Re: On disable_cost
Previous Message Antonin Houska 2024-10-18 11:50:47 Incorrect comment on pg_shadow view