Re: Setting pd_lower in GIN metapage

On Tue, Sep 12, 2017 at 3:51 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2017/09/11 18:13, Michael Paquier wrote:
>> On Mon, Sep 11, 2017 at 5:40 PM, Amit Langote wrote:
>>> On 2017/09/10 15:22, Michael Paquier wrote:
>>>> Coordinating efforts here would be nice. If you, Amit K, are taking
>>>> care of a patch for btree and hash, would you, Amit L, write the part
>>>> for GIN, BRIN and SpGist? This needs a careful lookup as many code
>>>> paths need a lookup so it may take time. Please note that I don't mind
>>>> double-checking this part if you don't have enough room to do so.
>>>
>>> Sorry, I didn't have time today to carefully go through the recent
>>> discussion on this thread (starting with Tom's email wherein he said he
>>> set the status of the patch to Waiting on Author). I will try tomorrow.
>>
>> Thanks for the update! Once you get to this point, please let me know
>> if you would like to work on a more complete patch for brin, gin and
>> spgist. If you don't have enough room, I am fine to produce something.
>
> I updated the patches for GIN, BRIN, and SP-GiST to include the following
> changes:
>
> 1. Pass REGBUF_STNADARD flag when registering the metapage buffer
>

I have looked into brin patch and it seems you have not considered all
usages of meta page. The structure BrinRevmap also contains a
reference to meta page buffer and when that is modified (ex. in
revmap_physical_extend), then also I think you need to consider using
REGBUF_STNADARD flag.

>
> Did I miss something from the discussion?
>

I think one point which might be missed is that the patch needs to
modify pd_lower for all usages of metapage, not only when it is first
time initialized.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com