From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: logical streaming of xacts via test_decoding is broken |
Date: | 2020-11-12 06:08:06 |
Message-ID: | CAA4eK1KGVD2GQBKKNtsrroiRb5cqisuLtSUg2Ww7KNP4YhgTxw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Nov 12, 2020 at 11:29 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
>
> > Another thing I am thinking let's just not expose skip_empty_stream to
> > the user and consider the behavior based on the value of
> > skip_empty_xacts. Internally, in the code, we can still have different
> > variables to distinguish between empty_xacts and empty_streams.
>
> Yeah, even I think in most of the cases it makes more sense to have
> skip_empty_xacts and skip_empty_stream similar values. So better we
> don't expose skip_empty_stream. I agree that we need to keep two
> variables to track the empty stream and empty xacts.
>
So, let's try to do this way and if we see any problems then we can re-think.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Dilip Kumar | 2020-11-12 06:14:05 | Re: logical streaming of xacts via test_decoding is broken |
Previous Message | David G. Johnston | 2020-11-12 06:08:03 | Re: Feature request: Improve allowed values for generate series |