| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Write Ahead Logging for Hash Indexes |
| Date: | 2016-09-16 06:42:40 |
| Message-ID: | CAA4eK1KEv0-ZHqCcsWzWEPWJCwN30hg+s0w9v0wDYdNV2MOMqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 14, 2016 at 12:04 AM, Jesper Pedersen
<jesper(dot)pedersen(at)redhat(dot)com> wrote:
> On 09/13/2016 07:41 AM, Amit Kapila wrote:
>>>
>
> I meant there is an extra ';' on the "if" statements:
>
> + if (BufferIsValid(bukcetbuf)); <--
>
> in hash_xlog_move_page_contents, hash_xlog_squeeze_page and
> hash_xlog_delete.
>
Okay, Thanks for pointing out the same. I have fixed it. Apart from
that, I have changed _hash_alloc_buckets() to initialize the page
instead of making it completely Zero because of problems discussed in
another related thread [1]. I have also updated README.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| wal_hash_index_v4.patch | application/octet-stream | 132.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2016-09-16 06:56:53 | Re: Hash Indexes |
| Previous Message | Amit Kapila | 2016-09-16 06:35:53 | Re: Hash Indexes |