| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Single transaction in the tablesync worker? |
| Date: | 2021-02-12 05:48:42 |
| Message-ID: | CAA4eK1KEKDakBEe-sNSN4k_mRStSfTfcFm7u1VD3NNg+e3mvcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 12, 2021 at 10:08 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Fri, Feb 12, 2021 at 2:46 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> >
> > Thanks, I have pushed the patch but getting one failure:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2021-02-12%2002%3A28%3A12
> >
> > The reason seems to be that we are trying to connect and
> > max_wal_senders is set to zero. I think we can write this without
> > trying to connect. The attached patch fixes the problem for me. What
> > do you think?
>
> Verified this with installcheck and modified configuration to have
> wal_level = minimal and max_wal_senders = 0.
> Tests passed. The changes look good to me.
>
Thanks, I have pushed the fix and the latest run of 'thorntail' has passed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-02-12 06:21:40 | Re: pg_cryptohash_final possible out-of-bounds access (per Coverity) |
| Previous Message | Greg Nancarrow | 2021-02-12 05:42:51 | Re: Parallel INSERT (INTO ... SELECT ...) |