Re: Fix comments atop pg_get_replication_slots

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: sirisha chamarthi <sirichamarthi22(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix comments atop pg_get_replication_slots
Date: 2022-11-21 07:38:12
Message-ID: CAA4eK1KE9cvuV3vvP3jSUmU1zXEYantCShBoCUGuYAWYZemkrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
<sirichamarthi22(at)gmail(dot)com> wrote:
>
> Hi Hackers,
>
> The comments atop seem to indicate that it is only showing active replication slots. The comment is ambiguous as it also shows all the slots including lost and inactive slots. Attached a small patch to fix it.
>

I agree that it is a bit confusing. How about "SQL SRF showing all
replication slots that currently exist on the database cluster"?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2022-11-21 07:39:58 Re: Reducing power consumption on idle servers
Previous Message Simon Riggs 2022-11-21 07:36:48 Re: Reducing power consumption on idle servers