Re: walsender.c comment with no context is hard to understand

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: walsender.c comment with no context is hard to understand
Date: 2024-07-08 05:50:45
Message-ID: CAA4eK1KDh+2BwtxCFs_Epkn9ueSD8G+hErJryW+e8v3AELcgWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 8, 2024 at 11:08 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> On Mon, Jul 08, 2024 at 08:46:19AM +0530, Amit Kapila wrote:
> > This sounds better but it is better to add just before we determine
> > am_cascading_walsender as is done in the attached. What do you think?
>
> Thanks! LGTM.
>

I would like to push this to HEAD only as we don't see any bug that
this change can prevent. What do you think?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2024-07-08 05:52:09 Re: SupportRequestRows support function for generate_series_timestamptz
Previous Message David Steele 2024-07-08 05:45:50 Re: replace strtok()