Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.
Date: 2023-01-06 11:59:56
Message-ID: CAA4eK1K8gbdPmGxra9bsdyu8CxMoG6Luj3WrPRVocHdan2xL9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 5, 2023 at 11:46 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Agreed. Attached the updated patch.
>

Thanks, the patch looks good to me. I think it would be probably good
to backpatch this but it has the potential to break some monitoring
scripts which were using the wrong columns for transaction id and spec
token number. As this is not a very critical issue and is not reported
till now, so it may be better to leave backpatching it. What do you
think?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2023-01-06 12:18:44 Re: [PATCH] psql: Add tab-complete for optional view parameters
Previous Message vignesh C 2023-01-06 11:51:42 Re: [PATCH] psql: Add tab-complete for optional view parameters