Fix typos in reorderbuffer.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix typos in reorderbuffer.c
Date: 2020-10-08 08:37:17
Message-ID: CAA4eK1K6zTpuqf_d7wXCBjo_EF0_B6Fz3Ecp71Vq18t=wG-nzg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

@@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb,
ReorderBufferTXN *txn)
ReorderBufferCleanupTXN(rb, subtxn);
}

- /* cleanup changes in the toplevel txn */
+ /* cleanup changes in the txn */
dlist_foreach_modify(iter, &txn->changes)
{
ReorderBufferChange *change;
@@ -1533,7 +1533,7 @@ ReorderBufferTruncateTXN(ReorderBuffer *rb,
ReorderBufferTXN *txn)
ReorderBufferTruncateTXN(rb, subtxn);
}

- /* cleanup changes in the toplevel txn */
+ /* cleanup changes in the txn */
dlist_foreach_modify(iter, &txn->changes)
{
ReorderBufferChange *change;

Both the above functions are recursive and will clean the changes for
both the top-level transaction and subtransactions. So, I feel the
comments should be accordingly updated.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v1-0001-Fix-typos-in-reorderbuffer.c.patch application/octet-stream 1.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-10-08 08:47:40 Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables
Previous Message Keisuke Kuroda 2020-10-08 08:35:45 Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables