From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Adjust the description of OutputPluginCallbacks in pg-doc |
Date: | 2023-01-19 11:19:52 |
Message-ID: | CAA4eK1K6t6SQn_FDKE2xKX7S4-xT-joCvVn8bCL7YL+KhU0ygw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 19, 2023 at 4:47 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jan 11, 2023 at 4:20 PM wangw(dot)fnst(at)fujitsu(dot)com
> <wangw(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc [1],
> > I think in the summary section, only the callback message_cb is not described
> > whether it is required or optional, and the description of callback
> > stream_prepare_cb seems inaccurate.
> >
> > And after the summary section, I think only the callback stream_xxx_cb section
> > and the callback truncate_cb section are not described this tag (are they
> > required or optional).
> >
> > I think we could improve these to be more reader friendly. So I tried to write
> > a patch for these and attach it.
> >
> > Any thoughts?
> >
>
> This looks mostly good to me. I have made minor adjustments in the
> attached. Do those make sense to you?
>
I forgot to mention that I intend to commit this only on HEAD as this
is a doc improvement patch.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-01-19 11:20:44 | Re: Add the ability to limit the amount of memory that can be allocated to backends. |
Previous Message | vignesh C | 2023-01-19 11:17:57 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |