Re: Skipping logical replication transactions on subscriber side

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skipping logical replication transactions on subscriber side
Date: 2021-12-06 05:17:00
Message-ID: CAA4eK1K2yKC-Eve+tACyfAkniy4VvLqiGU-F9Vtg0yNO7MjZzw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 3, 2021 at 12:12 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Dec 3, 2021 at 11:53 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > > But this syntax gives you flexibility, so we can also
> > > start with a simple implementation.
> > >
> >
> > Yeah, I also think so. BTW, what do you think of providing extra
> > flexibility of giving other options like 'operation', 'rel' along with
> > xid? I think such options could be useful for large transactions that
> > operate on multiple tables as it is quite possible that only a
> > particular operation from the entire transaction is the cause of
> > failure. Now, on one side, we can argue that skipping the entire
> > transaction is better from the consistency point of view but I think
> > it is already possible that we just skip a particular update/delete
> > (if the corresponding tuple doesn't exist on the subscriber). For the
> > sake of simplicity, we can just allow providing xid at this stage and
> > then extend it later as required but I am not very sure of that point.
>
> +1
>
> Skipping a whole transaction by specifying xid would be a good start.
>

Okay, that sounds reasonable, so let's do that for now.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-12-06 05:20:34 Re: parse_subscription_options - suggested improvements
Previous Message Kyotaro Horiguchi 2021-12-06 05:16:29 Re: [PATCH] support tab-completion for single quote input with equal sign