From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | "Wu, Fei" <wufei(dot)fnst(at)cn(dot)fujitsu(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Confusing comment for function ExecParallelEstimate |
Date: | 2019-06-07 00:25:56 |
Message-ID: | CAA4eK1K+6c1W6AkP1WFu_sVVnv1rw2oGH6iDV-tOB65Fe4BRkA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 6, 2019 at 8:12 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei <wufei(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
> >
> > Sorry, Last mail forget to CC the mailing list.
> >
> > Now the comment is confusing, Maybe someone should correct it.
> >
>
> Sure, for the sake of clarity, when this code was initially introduced
> in commit d1b7c1ff, the structure used was
> SharedPlanStateInstrumentation, but later when it got changed to
> Instrumentation structure in commit b287df70, we forgot to update the
> comment. So, we should backpatch this till 9.6 where it got
> introduced. I will commit this change by tomorrow or so.
>
Pushed. Note, I was not able to apply your patch using patch -p1 command.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Horiguchi Kyotaro | 2019-06-07 00:46:09 | Re: pg_checksums has an untranslatable string. |
Previous Message | Tom Lane | 2019-06-07 00:12:57 | Re: LLVM compile failing in seawasp |