From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
Subject: | Re: [PATCH] Provide more information to filter_prepare |
Date: | 2021-03-29 06:12:43 |
Message-ID: | CAA4eK1JzSf0sZ_yHAOHBfdEFytqdX=Jb8XN6gUiLDPx8Ud55sQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 25, 2021 at 2:07 PM Markus Wanner
<markus(dot)wanner(at)enterprisedb(dot)com> wrote:
>
> On 22.03.21 09:50, Markus Wanner wrote:
> > thank you for reconsidering this patch. I updated it to include the
> > required adjustments to the documentation. Please review.
>
> I tweaked the wording in the docs a bit, resulting in a v3 of this patch.
>
One minor comment:
- The callback has to provide the same static answer for a given
- <parameter>gid</parameter> every time it is called.
+ The callback may be invoked several times per transaction to decode and
+ must provide the same static answer for a given pair of
Why do you think that this callback can be invoked several times per
transaction? I think it could be called at most two times, once at
prepare time, then at commit or rollback time. So, I think using
'multiple' instead of 'several' times is better.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | tsunakawa.takay@fujitsu.com | 2021-03-29 06:15:16 | RE: libpq debug log |
Previous Message | Michael Paquier | 2021-03-29 05:47:33 | Re: Walsender may fail to send wal to the end. |