| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: elog(DEBUG2 in SpinLocked section. |
| Date: | 2020-06-02 08:42:37 |
| Message-ID: | CAA4eK1Jx6K_YidBoP+3Y6YJYCbULM=eDpN6v5KYTAxFd9oqYGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 2, 2020 at 2:05 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
> > Hello.
> >
> > I noticed that UpdateSpillStats calls "elog(DEBUG2" within
> > SpinLockAcquire section on MyWalSnd. The lock doesn't protect rb and
> > in the first place the rb cannot be modified during the function is
> > running.
> >
> > It should be out of the lock section.
Right.
>
> Thanks for the patch! It looks good to me.
>
The patch looks good to me as well. I will push this unless Fujii-San
wants to do it.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-06-02 08:57:40 | Re: OpenSSL 3.0.0 compatibility |
| Previous Message | Fujii Masao | 2020-06-02 08:35:48 | Re: elog(DEBUG2 in SpinLocked section. |