| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | kuroda(dot)hayato(at)fujitsu(dot)com, osumi(dot)takamichi(at)fujitsu(dot)com, smithpb2250(at)gmail(dot)com, vignesh21(at)gmail(dot)com, shveta(dot)malik(at)gmail(dot)com, dilipbalaut(at)gmail(dot)com, euler(at)eulerto(dot)com, m(dot)melihmutlu(at)gmail(dot)com, andres(at)anarazel(dot)de, marcos(at)f10(dot)com(dot)br, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Date: | 2023-01-31 09:42:14 |
| Message-ID: | CAA4eK1Jx2A=v2rj24pkhge_UDzhrx5WHbpCoyfMB6cOsuZsMOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 31, 2023 at 1:40 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> Hi, Kuroda-san, Thanks for the detailed study.
>
> At Tue, 31 Jan 2023 07:06:40 +0000, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> wrote in
> > Therefore, I think we can say that modern platforms that are supported by PostgreSQL define int as 32-bit.
> > It satisfies the condition sizeof(int) <= sizeof(int32), so we can keep to use INT_MAX.
>
> Yeah, I know that that's practically correct. Just I wanted to make
> clear is whether we (always) assume int == int32. I don't want to do
> that just because that works. Even though we cannot be perfect, in
> this particular case the destination space is explicitly made as
> int32.
>
So, shall we check if the result of parse_int is in the range 0 and
PG_INT32_MAX to ameliorate this concern? If this works then we need to
probably change the return value of defGetMinApplyDelay() to int32.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-01-31 09:53:21 | Re: Timeline ID hexadecimal format |
| Previous Message | Bharath Rupireddy | 2023-01-31 09:23:25 | Re: Reducing power consumption on idle servers |