| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix instability in subscription regression test |
| Date: | 2022-06-24 09:05:04 |
| Message-ID: | CAA4eK1Jv94dVP6qfbOM9PvnyzUWUHVgo2HiL02T25tzm3vv7sQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 24, 2022 at 8:07 AM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> >
> > +# wait for initial table synchronization to finish
> > +$node_subscriber->poll_query_until('postgres', $synced_query)
> >
> > We could probably slightly change the comment to say: "wait for table sync to
> > finish". Normally, we use initial table sync after CREATE SUBSCRIPTION. This is a
> > minor nitpick and I can take care of it before committing unless you think
> > otherwise.
>
> Thanks for reviewing, the suggestion looks good to me.
>
Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-06-24 09:05:43 | Re: tablesync copy ignores publication actions |
| Previous Message | Jelte Fennema | 2022-06-24 08:47:09 | [PATCH] Optimize json_lex_string by batching character copying |