Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description

On Wed, Oct 16, 2024 at 10:56 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Mon, Sep 9, 2024 at 01:15:32PM +1000, Peter Smith wrote:
> >
> > Me too. I created this thread primarily to get the description changed
> > to clarify this field represents a moment in time, rather than a
> > duration. So I will be happy with any wording that addresses that.
>
> I dug into the code and came up with the attached patch. "active" means
> there is a process streaming the slot, and the "inactive_since" time
> means the last time synchronous slot streaming was stopped. Doc patch
> attached.
>

Few comments:
=============
1.
<para>
- True if this slot is currently actively being used
+ True if this slot is currently currently being streamed
</para></entry>

currently shouldn't be used twice.

2.
- /* The time since the slot has become inactive */
+ /* The time slot sychronized was stopped. */
TimestampTz inactive_since;

Would it be better to say: "The time slot synchronization was stopped."?

3.
This is useful for slots on the
+ standby that are intended to be synced from a primary server

I think it is better to be explicit here and probably say: "This is
useful for slots on the standby that are being synced from a primary
server .."

--
With Regards,
Amit Kapila.