| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Kevin Grittner <kgrittn(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: old_snapshot_threshold allows heap:toast disagreement |
| Date: | 2016-08-03 11:20:33 |
| Message-ID: | CAA4eK1JtNAEh5pKufPFMBxbVmExPURXOMOmbhd9DK8FqE5hLgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 3, 2016 at 2:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Jul 28, 2016 at 7:29 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Yeah. Actually, consistent with the above, I discovered that as long
> as we consult both the active snapshot stack and the pairingheap of
> registered snapshots, it seems to be fine to just insist that we
> always get a snapshot back from the snapmgr and use that to initialize
> the TOAST snapshot. So I did it that way in the attached version.
>
> New patch attached.
>
Code looks good to me. I have not tested the patch.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-08-03 11:39:30 | Re: Surprising behaviour of \set AUTOCOMMIT ON |
| Previous Message | Greg Stark | 2016-08-03 10:29:39 | Re: Why we lost Uber as a user |