| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: backup manifests |
| Date: | 2020-03-25 06:53:23 |
| Message-ID: | CAA4eK1JsOvZaYAeXsU8tDvrycodPBn4-MUbo1hTZNwZaBRAO=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 24, 2020 at 10:30 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Mar 23, 2020 at 11:43 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > All others except one are passing now. See the summary of the failed
> > test below and attached are failed run logs.
> >
> > Test Summary Report
> > -------------------
> > t/003_corruption.pl (Wstat: 65280 Tests: 14 Failed: 0)
> > Non-zero exit status: 255
> > Parse errors: Bad plan. You planned 44 tests but ran 14.
> > Files=6, Tests=123, 164 wallclock secs ( 0.06 usr + 0.02 sys = 0.08 CPU)
> > Result: FAIL
>
> Hmm. It looks like it's trying to remove the symlink that points to
> the tablespace directory, and failing with no error message. I could
> set that permutation to be skipped on Windows, or maybe there's an
> alternate method you can suggest that would work?
>
We can use rmdir() for Windows. The attached patch fixes the failure
for me. I have tried the test on CentOS as well after the fix and it
passes there as well.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_003_corruption.patch | application/octet-stream | 661 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajkumar Raghuwanshi | 2020-03-25 07:22:11 | Re: WIP/PoC for parallel backup |
| Previous Message | k.jamison@fujitsu.com | 2020-03-25 06:24:32 | RE: [Patch] Optimize dropping of relation buffers using dlist |