From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | jcnaylor(at)gmail(dot)com |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: doc fix for pg_stat_activity.backend_type |
Date: | 2018-11-13 11:33:04 |
Message-ID: | CAA4eK1JsBg5qSqRegBQwQTDDOyX6iriwY3+c0Y1QRDdih5M==Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 13, 2018 at 3:37 PM John Naylor <jcnaylor(at)gmail(dot)com> wrote:
>
> On 11/13/18, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > Don't you need to remove <literal>background worker</literal>?
>
> It's handled in pgstat_get_backend_desc(), so I assumed not. If that's
> just a place holder, then it's probably better left out, as in the
> attached.
>
I don't think 'background worker' can be displayed as backend_type.
Do you see any way it can be displayed as backend_type?
> > + In addition, extensions may have additional types.
> >
> > How about: "In addition, background workers registered by extensions
> > may have additional types."?
>
> Sounds good to me -- I've included this language.
>
LGTM. I will wait for a day or so, if nobody has any comments, I will
push your patch.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Ideriha, Takeshi | 2018-11-13 11:40:38 | RE: Copy data to DSA area |
Previous Message | Christoph Berg | 2018-11-13 10:40:05 | [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |