| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Failed assertion in joinrels.c |
| Date: | 2016-08-09 13:19:01 |
| Message-ID: | CAA4eK1Js5kr4EZFCwYWtXpvvR1-65xTUuLueV-yH04Faq-oAgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 8, 2016 at 6:00 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Mon, Aug 8, 2016 at 5:23 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>
>> Did you consider to use ERRCODE_UNDEFINED_COLUMN with error messages
>> like: "type %u does not exit" or "type id %u does not exit"? Errorcode
>> ERRCODE_UNDEFINED_COLUMN seems to be used for syscache lookup failure
>> cases at certain places in code.
>
>
> But I think, OBJECT will be more appropriate than COLUMN at this place.
>
Okay, then how about ERRCODE_UNDEFINED_OBJECT? It seems to be used in
almost similar cases.
> However I can change error message to "type id %u does not exit" if this
> seems better ?
>
I think that is better.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2016-08-09 15:18:10 | Re: No longer possible to query catalogs for index capabilities? |
| Previous Message | Shay Rojansky | 2016-08-09 12:59:25 | Re: Slowness of extended protocol |