From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Backpatch b61d161c14 (Introduce vacuum errcontext ...) |
Date: | 2020-06-30 04:00:54 |
Message-ID: | CAA4eK1JoFLAeP3aDaYr3jq3uaoNY=Qoj=tB_HjMtMgvErtybLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 26, 2020 at 9:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jun 26, 2020 at 7:25 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> >
> > Comments:
> >
> > > * The index name is saved only during this phase and restored immediately
> >
> > => I wouldn't say "only" since it's saved during lazy_vacuum: index AND cleanup.
> >
> > >update_vacuum_error_info(LVRelStats *errinfo, LVSavedErrInfo *oldpos, int phase,
> >
> > => You called your struct "LVSavedErrInfo" but the variables are still called
> > "pos". I would call it olderrinfo or just old.
> >
>
> Fixed both of the above comments. I used the variable name as saved_err_info.
>
> > Also, this doesn't (re)rename the "cbarg" stuff that Alvaro didn't like, which
> > was my 0001 patch.
> >
>
> If I am not missing anything then that change was in
> lazy_cleanup_index and after this patch, it won't be required because
> we are using a different variable name.
>
> I have combined both the patches now.
>
I am planning to push this tomorrow if there are no further
suggestions/comments.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | higuchi.daisuke@fujitsu.com | 2020-06-30 04:01:15 | RE: [Bug fix]There is the case archive_timeout parameter is ignored after recovery works. |
Previous Message | Amit Kapila | 2020-06-30 03:58:33 | Re: Resetting spilled txn statistics in pg_stat_replication |