Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Date: 2022-07-21 10:10:57
Message-ID: CAA4eK1JnYk97T=TMxHAygFN2k5TujVBuspFDvVjncqCG-xdtyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 21, 2022 at 10:03 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jul 21, 2022 at 09:54:05AM +0530, Amit Kapila wrote:
> > Yeah, it is not very clear to me either. I think this won't be
> > difficult to change one or another way depending on future needs. At
> > this stage, it appeared to me that bitmask is a better way to
> > represent this information but if you and other feels using enum is a
> > better idea then I am fine with that as well.
>
> Please don't get me wrong :)
>
> I favor a bitmask over an enum here, as you do, with a clean
> layer for those flags.
>

Okay, let's see what Peter Smith has to say about this as he was in
favor of using enum here?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-07-21 10:13:09 Re: add a missing space
Previous Message Amit Kapila 2022-07-21 10:08:11 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher