| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improving the latch handling between logical replication launcher and worker processes. |
| Date: | 2024-07-08 09:55:35 |
| Message-ID: | CAA4eK1JnP6hb1vc--MbUq5CZf_6KakacMq5L-MLj7oVFBJk9Rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 5, 2024 at 6:38 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
>
> Your solution with an additional latch seems better because it makes
> WaitForReplicationWorkerAttach() react more quickly, without the 10 s
> wait. I'm surprised we have that in the first place, 10 s seems like a
> pretty long time to wait for a parallel apply worker to start. Why was
> that ever OK?
>
Isn't the call wait for 10 milliseconds? The comment atop
WaitLatch("The "timeout" is given in milliseconds...) indicates the
timeout is in milliseconds.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2024-07-08 10:08:10 | Re: Incorrect results from numeric round() and trunc() |
| Previous Message | Joel Jacobson | 2024-07-08 09:55:28 | Re: pgsql: Add pg_get_acl() to get the ACL for a database object |