| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2022-12-02 11:35:59 |
| Message-ID: | CAA4eK1JnAjWOm6HSTrvqui8JCDhuNguyfdQ73WPnXXh6nH=MaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 2, 2022 at 4:57 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> handle_streamed_transaction()
>
> ```
> + if (apply_action == TRANS_LEADER_SEND_TO_PARALLEL)
> + pa_send_data(winfo, s->len, s->data);
> + else
> + stream_write_change(action, &original_msg);
> ```
>
> Comments are needed here, 0001 has that bu removed in 0002.
> There are some similar lines.
>
I have suggested removing it because they were just saying what is
evident from the code and doesn't seem to be adding any value. I would
say they were rather confusing.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-12-02 12:04:11 | Re: pg_upgrade: Make testing different transfer modes easier |
| Previous Message | Alexander Korotkov | 2022-12-02 11:33:33 | Re: Fix gin index cost estimation |