| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, osumi(dot)takamichi(at)fujitsu(dot)com, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Decoding speculative insert with toast leaks memory |
| Date: | 2021-06-25 03:20:03 |
| Message-ID: | CAA4eK1JmdvAWXB89q2qYMm_3endNbrVsJ5L6tu7LZePQaiCCnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 24, 2021 at 11:04 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jun 24, 2021 at 12:25:15AM -0400, Tom Lane wrote:
> > Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> >> Okay, I'll change this in back branches and HEAD to keep the code
> >> consistent, or do you think it is better to retain the order in HEAD
> >> as it is and just change it for back-branches?
> >
> > As I said, I'd keep the natural ordering in HEAD.
>
> Yes, please keep the items in an alphabetical order on HEAD, and just
> have the new item at the bottom of the enum in the back-branches.
> That's the usual practice.
>
Okay, I have back-patched the change till v11 because before that
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_ABORT is already at the end.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-06-25 03:49:48 | PG Docs for ALTER SUBSCRIPTION REFRESH PUBLICATION - copy_data option |
| Previous Message | Amit Kapila | 2021-06-25 03:17:41 | Re: Doc chapter for Hash Indexes |