Re: Questions/Observations related to Gist vacuum

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Questions/Observations related to Gist vacuum
Date: 2019-10-23 11:14:39
Message-ID: CAA4eK1JjKtOc0=HxSGHrUuDuumpNc6DBj70TkHvFD-_yje658Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 22, 2019 at 2:17 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Oct 22, 2019 at 10:53 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > > Basically, only IndexBulkDeleteResult is now shared across the stage
> > > so we can move all members to GistVacState and completely get rid of
> > > GistBulkDeleteResult?
> > >
> >
> > Yes, something like that would be better. Let's try and see how it comes out.
> I have modified as we discussed. Please take a look.
>

Thanks, I haven't reviewed this yet, but it seems to be on the right
lines. Sawada-San, can you please prepare the next version of the
parallel vacuum patch on top of this patch and enable parallel vacuum
for Gist indexes? We can do the review of this patch in detail once
the parallel vacuum patch is in better shape as without that it
wouldn't make sense to commit this patch.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2019-10-23 11:42:47 Re: jsonb_set() strictness considered harmful to data
Previous Message Amit Kapila 2019-10-23 10:50:33 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions